Skip to content

Scrap Vehicles 1.5 #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

Killermankey
Copy link
Contributor

@Killermankey Killermankey commented Apr 16, 2025

About The Pull Request

adds even more mecha vehicles into the game, and some nefarious items for traitors to use.

Why It's Good For The Game

the giant drill vehicle is a way to break reinforced walls fast, but with nearly no health to defend itself with.
and a tank, to fight mechs and cause havoc.

Changelog

🆑
add: Devitt Mk3 Light tank
add: minigun peashooter for trash tank
add: giant sheet metal drill vehicle
/:cl:

@notghosti
Copy link
Collaborator

image
Are the two tanks on metastation placed intentional?

@notghosti notghosti added the Feature: enhancement New feature or request label Apr 16, 2025
@Killermankey
Copy link
Contributor Author

image Are the two tanks on metastation placed intentional?

FUCK
it was for testing Iforgot to delete it off the map

Comment on lines +53 to +61
// BEGIN_INTERNALS
// END_INTERNALS
// BEGIN_FILE_DIR
#define FILE_DIR .
// END_FILE_DIR
// BEGIN_PREFERENCES
// END_PREFERENCES
// BEGIN_INCLUDE
// END_INCLUDE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo changes to this file

Comment on lines +89 to +92




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this extra spacing at the end

icon_state = "devitt-broken"
welder_salvage = list(/obj/item/stack/sheet/plasteel, /obj/item/stack/sheet/iron, /obj/item/stack/rods) //get it, it's a glass cannon


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newlines

@@ -0,0 +1,66 @@
/obj/vehicle/sealed/mecha/devitt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move all this out of the monkestation folder if it's not too much trouble

name = "peashooter minigun"
desc = "through the power of special syndicate glue,multiple peashooters have been strapped together and the fireate increased."
icon_state = "mecha_minipea"
equip_cooldown = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equip_cooldown is defined twice

icon_state = "mecha_light_tank_cannon"
fire_sound = 'sound/weapons/gun/general/lighttankgun.ogg'
harmful = TRUE
equip_cooldown = 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equip_cooldown defined twice

desc = "you reckon this machinegun could've existed before planes were a thing. Despite the calibre it doesn't do that much.It has no autoloader or mounting bolts, you doubt it would work on anything else."
icon_state = "mecha_light_tank_mg"
fire_sound = 'sound/weapons/gun/l6/shot.ogg'
equip_cooldown = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equip_cooldown defined twice

@@ -76,6 +76,7 @@
team.update_action_icons()
for(var/datum/mind/brother as anything in team.members)
to_chat(brother.current, span_boldnotice("[owner.mind.name || owner.real_name] has chosen [chosen_gear.name] as your team's gear! You may drop-pod it in at any time using the Summon Gear action!"), type = MESSAGE_TYPE_INFO, avoid_highlighting = (brother == owner.mind))
var/devitt = /datum/bb_gear/devitt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

name = "Giant drill"
icon_state = "mecha_giantdrill"
desc = "what looks to be a drill atleast the size of you, tears through anything like butter."
equip_cooldown = 10 // it is not slow as shit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
equip_cooldown = 10 // it is not slow as shit
equip_cooldown = 1 SECONDS // it is not slow as shit

@@ -30,6 +50,8 @@
mech_flags = EXOSUIT_MODULE_AMBULANCE
honk_range = 1 //only directly besides, are affected
tactile_message = "HARM ALARM"
energy_drain = 400
equip_cooldown = 250
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
equip_cooldown = 250
equip_cooldown = 25 SECONDS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approval: admin approved PR is approved by admins Feature: enhancement New feature or request Process: should testmerge PR should be testmerged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants